Fix GH-158: Replace empty() with strict string comparison for sdesc/ldesc #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/ldesc Both sdesc and ldesc are always initialized as "" in storeInfo() and populated with htmlentities(trim(...)) results, so they are always strings. Using empty() is overly broad here since it would also treat a legitimate "0" value as empty. Replace with === "" for precision. The third occurrence in Package/PEAR/Web.php was already removed in commit 53f9afe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
empty()checks with=== ""forsdescandldescinIndex.php""instoreInfo()(line 213-214) and populated viahtmlentities(trim(...)), so they are always strings —empty()is overly broad and would incorrectly treat a legitimate"0"as emptyPackage/PEAR/Web.phpmentioned in the issue was already removed in commit 53f9afeFixes #158