Skip to content

feat(caddy): upgrade to Caddy 2.9.0#1302

Merged
dunglas merged 2 commits intomainfrom
feat/caddy-2.9
Jan 6, 2025
Merged

feat(caddy): upgrade to Caddy 2.9.0#1302
dunglas merged 2 commits intomainfrom
feat/caddy-2.9

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Jan 5, 2025

Upgrade to Caddy 2.9 and leverage the new first_exist_fallback try policy (caddyserver/caddy#6699).

@dunglas dunglas merged commit c2ca4db into main Jan 6, 2025
37 of 40 checks passed
@dunglas dunglas deleted the feat/caddy-2.9 branch January 6, 2025 12:34
@AlliBalliBaba
Copy link
Contributor

@dunglas I noticed that this block will also cause a file access on every request even though its only purpose is to redirect on directory index files from /path -> /path/ (the 'canonical' path). Not sure how to optimize this, but it would be another opportunity to minimize file access.

https://github.com/dunglas/frankenphp/blob/c2ca4dbf03048d7d82c9b069646d64d1454b6abb/caddy/caddy.go#L559-L582

image

@dunglas
Copy link
Member Author

dunglas commented Jan 6, 2025

Yes, I already discussed this one with @francislavoie but I'm not sure we can find a generic solution to prevent it.

The best we can do is probably some custom config like this one, or to introduce a cache. https://github.com/dunglas/symfony-docker/blob/main/frankenphp/Caddyfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants