Skip to content

Conversation

@glaucocustodio
Copy link
Contributor

No description provided.

@glaucocustodio glaucocustodio mentioned this pull request Oct 6, 2015
lib/floki.ex Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function could be private.

@philss
Copy link
Owner

philss commented Oct 7, 2015

@glaucocustodio

I added some comments in the PR. Please check.
Also, I think you could change the variable name of first_dom to node, in order to keep consistency.

This is a very nice feature, thanks! 😃

@glaucocustodio
Copy link
Contributor Author

Nice. I thought about keeping these functions you mentioned as private, but I didn't do in order to test them..
Anyway, I will do the requested changes. Thanks for the tips!

philss added a commit that referenced this pull request Oct 7, 2015
Add function to convert node tree back to HTML
@philss philss merged commit 263f0e5 into philss:master Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants