Support for Stripe and Authorize.Net #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed AmountInDecimal from ProcessPaymentRequest. I don't think the api wrapper should try to handle currency corrections. User should know what the Spreedly currency unit is for their case.
Also fix build error in PaymentModule
Owner
There was a problem hiding this comment.
this is something i use, why has this been removed?
Author
There was a problem hiding this comment.
It seems to me that unit conversions should be the responsibility of the user rather than the library. This property would be useful (and missleading) for users working in non-base100 currencies.
If you want to keep it in the library maybe move it into a separate extension.
Also update request names to verbs
This is ugly, but I don't know of a better work around except IXmlSerializable
Author
|
This branch has a bunch of features I need for my project. It is dependent on PR #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.