Fix thread safety of multiple Server instances in the same process
#3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
fix-multi-server-threadsafe
branch
from
3f58281 to
de62bcc
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-multi-server-threadsafe
branch
from
de62bcc to
89b4224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory corruption issue which can be encountered in
perspective-pythonorperspective-rswhen:Serverinstances exist in the same process, andViewinstances withexpressionsfields, andViewmethods on each are called from separate threads concurrentlyThis has technically been an issue since Perspective
v3.0, but only because before this version, #1 in this list was not possible as there was no public API for instancing multiple Servers.