Skip to content

Minimal fix for sqlite3#26

Merged
schengawegga merged 1 commit intopear:trunkfrom
remicollet:patch-2
Jan 17, 2024
Merged

Minimal fix for sqlite3#26
schengawegga merged 1 commit intopear:trunkfrom
remicollet:patch-2

Conversation

@remicollet
Copy link
Contributor

This allow to run test suite with sqlite3 driver

BTW test suite is not ready, lot of failures, some related to resource-to-object conversion

Running 19 tests
FAIL [ 1/19] DB_driver::connect[driver/01connect.phpt]
PASS [ 2/19] DB_driver::fetch[driver/02fetch.phpt]
FAIL [ 3/19] DB_driver::simpleQuery[driver/03simplequery.phpt]
PASS [ 4/19] DB_driver::numCols[driver/04numcols.phpt]
FAIL [ 5/19] DB_driver::sequences[driver/05sequences.phpt]
PASS [ 6/19] DB_driver::prepare/execute[driver/06prepexec.phpt]
FAIL [ 7/19] DB_driver::affectedRows[driver/08affectedrows.phpt]
PASS [ 8/19] DB_driver::numRows[driver/09numrows.phpt]
FAIL [ 9/19] DB_driver::error mapping[driver/10errormap.phpt]
SKIP DB_driver::transaction test[driver/11transactions.phpt](reason: this driver does not support transactions)
FAIL [11/19] DB_driver::row limit[driver/13limit.phpt]
PASS [12/19] DB_driver::fetchmode object[driver/14fetchmode_object.phpt]
FAIL [13/19] DB_driver::quote[driver/15quote.phpt]
FAIL [14/19] DB_driver::tableInfo[driver/16tableinfo.phpt]
PASS [15/19] DB_driver::query[driver/17query.phpt]
FAIL [16/19] DB_driver::get[driver/18get.phpt]
FAIL [17/19] DB_driver::getListOf[driver/19getlistof.phpt]
PASS [18/19] DB_driver::locale[driver/20locale.phpt]
FAIL [19/19] DB_driver::freeResult[driver/21freeResult.phpt]

);

if (getenv('MYSQL_TEST_USER') !== '') {
if (getenv('MYSQL_TEST_USER')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not set, return false, not empty string

@schengawegga schengawegga merged commit a01ac85 into pear:trunk Jan 17, 2024
@remicollet remicollet deleted the patch-2 branch January 17, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants