Skip to content

PHP8.2 ready#21

Merged
ashnazg merged 5 commits intopear:trunkfrom
schengawegga:PHP8.2_ready
Nov 27, 2023
Merged

PHP8.2 ready#21
ashnazg merged 5 commits intopear:trunkfrom
schengawegga:PHP8.2_ready

Conversation

@schengawegga
Copy link
Collaborator

Some changes to become PHP8.2 ready

@schengawegga schengawegga added this to the v1.12.0 milestone Nov 4, 2023
@CloCkWeRX
Copy link
Member

I'm not sure about this.
Pear DB did its thing.
Pear MDB2 came along, and it was an improvement.
PHP then brought in PHP's PDO approach, and that was (another) improvement.

What PEAR specific packages are relying on this, and more importantly, should they be?

@schengawegga
Copy link
Collaborator Author

I'm not sure about this.
Pear DB did its thing.
Pear MDB2 came along, and it was an improvement.
PHP then brought in PHP's PDO approach, and that was (another) improvement.

What PEAR specific packages are relying on this, and more importantly, should they be?

But there are users out there wich are using still pear/db in their projects. And changing the database abstraction class to MDB or PDO takes a lot of time and work, depending on how big the project is. So we should keep this package alive for all these long living projects.

And pear/auth, pear/log or pear/mail_queue uses this package optional for database transactions, for example.

So my goal is, to keep as many pear packages alive, as my time allows. Because I use several of this packages in my projects, too. And I know how frustrating it can be, if a deep implemented package was abandoned. So I can also give something back to the community.

@ashnazg
Copy link
Member

ashnazg commented Nov 26, 2023

@schengawegga since this package is marked as working with PHP 5.0.0, do you know for sure these changes also work on PHP5?

@ashnazg ashnazg self-assigned this Nov 26, 2023
@ashnazg
Copy link
Member

ashnazg commented Nov 27, 2023

I pulled the branch and got a good-as-normal Travis build, so I'm convinced.

@ashnazg ashnazg merged commit 4efd340 into pear:trunk Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants