fix: use multipart copy for S3 objects larger than 5 GiB #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CopyObject API has a 5 GiB limit. For objects exceeding this, Copy now falls back to multipart copy using CreateMultipartUpload + UploadPartCopy + CompleteMultipartUpload. The fallback is triggered when CopyObject returns EntityTooLarge or InvalidRequest with a "copy source is larger" message (the actual error S3 returns in practice). Uses 5 GiB part size to minimize API calls since the copy is entirely server-side. Closes peak#29
l1n
requested review from
ilkinulas and
seruman
and removed request for
a team
The bitnami/minio:2023.7.18 image was removed from Docker Hub, breaking all test jobs. Switch to running the official minio/minio image as a background docker container in a step instead of a service container, since GitHub Actions services do not support passing command arguments and the official image requires 'server /data'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CopyObjectAPI has a 5 GiB limit. For objects exceeding this,Copynow falls back to multipart copy usingCreateMultipartUpload+UploadPartCopy+CompleteMultipartUpload.Closes #29
Details
CopyObjectreturnsEntityTooLargeorInvalidRequestwith a "copy source is larger" message (the actual error S3 returns in practice).context.Background()so cleanup succeeds even if the parent context is cancelled.CreateMultipartUpload.ctxthrough toCopyObjectWithContext(previously unused).CI fix
Replaces the removed
bitnami/minio:2023.7.18Docker Hub image with the officialminio/minioimage run as a background container step, fixing CI that has been broken since the bitnami image was removed.Testing
isCopySourceTooLargeError(both error codes, negative cases)CopyObjectfailure →HeadObject→CreateMultipartUpload→UploadPartCopyx2 →CompleteMultipartUpload