Major revision #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMPORTANT] completely rewrote logic to have barcode-first approach to simulation
Previously, the simulator created molecules, droplets, and overall just tried to digitally mimic 10X chemistry. The new approach now first chooses a barcode, then decides how many molecules will be associated with it, then decides from what chromosomes/intervals those molecules will be from. This approach solves a major flaw of the previous implementation: unrelated molecules sharing a barcode can now come from any chromosome/interval in the haplotype, whereas previously these barcode-clashing events only occurred on the same chromosome/interval. This new approach is a more accurate representation of how clashing occurs.