Add minimum supported python version is 3.7#41
Closed
2xyo wants to merge 1 commit intopassivetotal:masterfrom
Closed
Add minimum supported python version is 3.7#412xyo wants to merge 1 commit intopassivetotal:masterfrom
2xyo wants to merge 1 commit intopassivetotal:masterfrom
Conversation
Collaborator
|
Thank you for submitting this - yes, you are correct, those methods in the This library never specified a minimum Python version, so introducing it now is a big change that could create problems for other libraries that depend on it. We need to make a decision on which version we will support, and plan for how that will impact dependent libraries. My initial thinking is that 3.6 is reasonable, but that will require some backporting to patch in a version of Due to these issues, I will close this PR without merging it in, but I have created a new issue #42 to track the problem. Feedback welcome on this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
date.fromisoformatis used and it's available from python 3.7 according to https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformatPR edited online and not tested 😅