Skip to content

BUG: fix memory leak in JSON datetime serialization #62217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUG: fix memory leak in JSON datetime serialization #62217

wants to merge 2 commits into from
+11 −1

Conversation

Alvaro-Kothe
Copy link
Contributor

@Alvaro-Kothe Alvaro-Kothe commented Aug 29, 2025 •
edited
Loading

@Alvaro-Kothe Alvaro-Kothe mentioned this pull request Aug 29, 2025
Closed
3 tasks
@swt2c
Copy link
Contributor

swt2c commented Aug 29, 2025

Thanks @Alvaro-Kothe, I can confirm this resolves the memory leak that I am seeing. Also, your solution makes sense.

👍

@mroeschke mroeschke requested a review from WillAyd August 29, 2025 19:02
@Alvaro-Kothe Alvaro-Kothe marked this pull request as ready for review August 29, 2025 19:04
swt2c
swt2c reviewed Aug 29, 2025
View reviewed changes
Copy link
Contributor

@swt2c swt2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might also need to add a GET_TC(tc)->freeCStr = 1; in Object_getBigNumStringValue

@Alvaro-Kothe
Copy link
Contributor Author

Thanks for pointing that out. Just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

1 more reviewer

@swt2c swt2c swt2c left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: memory leak in to_json when converting DateTime values
2 participants
@Alvaro-Kothe @swt2c