Preserve freq in TimedeltaIndex subtraction #62214
Open
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chenghaoxiang
force-pushed
the
new-feature
branch
2 times, most recently
from
eec1039 to
2e1bf0c
Compare
pandas/core/arrays/datetimelike.py
Outdated
| elif ( | ||
| lib.is_np_dtype(self.dtype, "M") | ||
| and isinstance(other, Timestamp) | ||
| and cast("DatetimeArray", self).tz == other.tz |
There was a problem hiding this comment.
Tz check should be unnecessary; this should only work for Day freqs.
|
Can you add a test for the fix |
Chenghaoxiang
force-pushed
the
new-feature
branch
from
2e1bf0c to
e45f984
Compare
Chenghaoxiang
force-pushed
the
new-feature
branch
from
e45f984 to
a956f9b
Compare
|
Certainly. I've added a test case and updated the PR. Please let me know if anything else is needed. |
| @@ -1089,6 +1089,8 @@ def _get_arithmetic_result_freq(self, other) -> BaseOffset | None: | |||
| # e.g. TestTimedelta64ArithmeticUnsorted::test_timedelta | |||
| # Day is unambiguously 24h | |||
| return self.freq | |||
| elif lib.is_np_dtype(self.dtype, "M") and isinstance(other, Timestamp): | |||
There was a problem hiding this comment.
Only in case where freq is Day
| ], | ||
| ) | ||
| @pytest.mark.parametrize("periods", [1, -2, 0]) | ||
| def test_shift_after_dti_sub_timestamp_various_inputs(dti, ts, periods): |
There was a problem hiding this comment.
You don’t need all this. Just one test in tests.indexes.dattimes.arithmetic for datetimeindex-timestamp retaining freq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.