fix: resolve 5 failing tests in core package#22
Merged
Conversation
- agent.test.ts: Fix "rejects when already processing" test by properly setting isProcessing state before calling chat(), matching the test's intent - file-system.test.ts: Add node:dns/promises mock to prevent real DNS lookups in downloadFileExecutor tests, which caused 4 timeouts due to SSRF protection https://claude.ai/code/session_01MYhaSC3uFt1bNhWETnowde
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting isProcessing state before calling chat(), matching the test's intent
in downloadFileExecutor tests, which caused 4 timeouts due to SSRF protection
https://claude.ai/code/session_01MYhaSC3uFt1bNhWETnowde