As an OC support user I want be able to filter by unique X-Request-ID header so I can tracing requests in apache and owncloud logs

[nasli]

As @butonic suggested owncloud/ios-legacy#950

owncloud/core#28144 has been merged. It will use the value of a X-Request-ID header as the request id in log files to allow linking events on the client to events in the apache and owncloud logs.

AC:

• Generate a string to use as unique id.
  • 20-200 chars
  • only [a-zA-Z0-9-+/_=.:] allowed
• Use it in the client log
• Send it as X-Request-ID header on every request

---

Tasks

[felix-schwarz]

This should be pretty easy to add.

Should every request ID be unique?
Or should it be built from the combination of a [client-ID] + [random string for every request]?

[michaelstingl]

I'd say random string only. User agent is already available in the header of http request. @butonic for more input?

This is the related issue for the desktop client: owncloud/client#5853 (commit: owncloud/client@1fb68e8)

[butonic]

all request ids must be unique. uuid v5 is fine. uuid v1 would leak the mac / allow tracking the client. Hm ... maybe that is exactly what we want? If you use more than one ios device how can the admin distinguish the requests on the server side? Agent string might be the same. user will be the same. IP might be the same if behind a NAT ...
The header contains auth / session credentials so he can be tracked anyway. But the admin would be able to re identify any device because the mac would be the same in the future ...
Also the X-Request-ID is user supplied ... so anything can be faked and is unreliable. It should be a random string. uuid v5 is based off a namespace, which in theory could be a client id ...

go with a random uuid v4. full random. we can change it later if necessary.

[felix-schwarz]

This is implemented as of 6534f98.