[stable10] #27854 non existing folder skeletondirectory#29379
Merged
phil-davis merged 1 commit intostable10from Oct 29, 2017
Merged
[stable10] #27854 non existing folder skeletondirectory#29379phil-davis merged 1 commit intostable10from
phil-davis merged 1 commit intostable10from
Conversation
added new test throw Exception on false config catch Exception and write error to Log
Contributor
Author
|
@PVince81 cherry-pick done from stable 10 to stable 10. Here we go with the PR |
Codecov Report
@@ Coverage Diff @@
## stable10 #29379 +/- ##
==============================================
- Coverage 59.03% 59.01% -0.03%
- Complexity 17723 17725 +2
==============================================
Files 1060 1060
Lines 59411 59415 +4
==============================================
- Hits 35075 35065 -10
- Misses 24336 24350 +14
Continue to review full report at Codecov.
|
Contributor
|
Backport of #29367 |
9 tasks
phil-davis
approved these changes
Oct 29, 2017
87 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new test
throw Exception on false config
catch Exception and write error to Log
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: