Skip to content

[stable10] #27854 non existing folder skeletondirectory#29379

Merged
phil-davis merged 1 commit intostable10from
#27854-non-existing-folder-skeletondirectory-stable-10
Oct 29, 2017
Merged

[stable10] #27854 non existing folder skeletondirectory#29379
phil-davis merged 1 commit intostable10from
#27854-non-existing-folder-skeletondirectory-stable-10

Conversation

@Gandolf90
Copy link
Contributor

@Gandolf90 Gandolf90 commented Oct 28, 2017

added new test
throw Exception on false config
catch Exception and write error to Log

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

added new test
throw Exception on false config
catch Exception and write error to Log
@Gandolf90
Copy link
Contributor Author

@PVince81 cherry-pick done from stable 10 to stable 10. Here we go with the PR

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #29379 into stable10 will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29379      +/-   ##
==============================================
- Coverage       59.03%   59.01%   -0.03%     
- Complexity      17723    17725       +2     
==============================================
  Files            1060     1060              
  Lines           59411    59415       +4     
==============================================
- Hits            35075    35065      -10     
- Misses          24336    24350      +14
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 66.66% <100%> (-2.48%) 221 <0> (+1)
lib/private/User/Session.php 63.14% <100%> (+0.52%) 119 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6f6ca...0b263ad. Read the comment docs.

@phil-davis phil-davis changed the title #27854 non existing folder skeletondirectory [stable10] #27854 non existing folder skeletondirectory Oct 29, 2017
@phil-davis
Copy link
Contributor

Backport of #29367

@phil-davis phil-davis merged commit 554e630 into stable10 Oct 29, 2017
@phil-davis phil-davis deleted the #27854-non-existing-folder-skeletondirectory-stable-10 branch October 29, 2017 01:47
@PVince81 PVince81 added this to the old milestone Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants