[stable10] Lazy connect to federated share, not in storage constructor#29314
Merged
[stable10] Lazy connect to federated share, not in storage constructor#29314
Conversation
Don't connect directly to the remote share inside the storage constructor. Defer this to the lazy initialization routine, which will then correctly configure the remote root using the discovery manager.
9 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #29314 +/- ##
==============================================
+ Coverage 58.4% 58.42% +0.02%
- Complexity 17695 17701 +6
==============================================
Files 1059 1059
Lines 59344 59355 +11
==============================================
+ Hits 34657 34681 +24
+ Misses 24687 24674 -13
Continue to review full report at Codecov.
|
jvillafanez
approved these changes
Oct 20, 2017
This was referenced Nov 8, 2017
87 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29275 to stable10