[stable10] Put attributes into generated XML

[DeepDiver1975]

backport of #29230 to stable10

[codecov]

Codecov Report

Merging #29303 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable10   #29303      +/-   ##
==============================================
- Coverage        58.4%    58.4%   -0.01%     
- Complexity      17693    17695       +2     
==============================================
  Files            1059     1059              
  Lines           59341    59344       +3     
==============================================
  Hits            34657    34657              
- Misses          24684    24687       +3

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/api.php	41.88% <0%> (-0.55%)	80 <0> (+2)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef290c2...ece616a. Read the comment docs.

[phil-davis]

A Jenkins restart overnight caused Jenkins to fail here (and on many other PRs) so I rebased this to trigger all CI again.
codecov fails. What is the policy with this?

1. for backports - if the code in master was accepted and merged, then it is by definition acceptable as long as the backport includes the same code changes (and tests if any)? If so, then is there any point giving a codecov fail on backports? or any point running codecov on backports?

2. for changes in master - if someone fixes some little bug, then they are responsible to write tests to cover the new/changed code fixing the bug, but if there are no tests existing for the area of code they changed, are they now responsible to create a (new) set of unit tests for the class(es) that they were unlucky enough to have touched?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.