Skip to content

log exception#29227

Merged
DeepDiver1975 merged 1 commit intomasterfrom
dont-swallow-exceptions
Oct 13, 2017
Merged

log exception#29227
DeepDiver1975 merged 1 commit intomasterfrom
dont-swallow-exceptions

Conversation

@butonic
Copy link
Contributor

@butonic butonic commented Oct 12, 2017

Don't swallow exceptions 😞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add the message to logException call

            $this->logger->logException($e, ['message' => "Exception trying to decrypt file <$path> for user <$uid>", 'app' => __CLASS__]);

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Oct 12, 2017

and tests hate you .... ❤️

@butonic butonic force-pushed the dont-swallow-exceptions branch 2 times, most recently from dba51de to c33d9dc Compare October 12, 2017 15:05
@DeepDiver1975 DeepDiver1975 force-pushed the dont-swallow-exceptions branch from c33d9dc to 3e04332 Compare October 13, 2017 10:19
@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #29227 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29227      +/-   ##
============================================
- Coverage     59.39%   59.39%   -0.01%     
  Complexity    17164    17164              
============================================
  Files          1027     1027              
  Lines         57221    57224       +3     
============================================
+ Hits          33989    33990       +1     
- Misses        23232    23234       +2
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Encryption/DecryptAll.php 67.5% <33.33%> (-0.88%) 33 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5182ced...3e04332. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit c13468d into master Oct 13, 2017
@DeepDiver1975 DeepDiver1975 deleted the dont-swallow-exceptions branch October 13, 2017 14:53
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants