Replace JS centering and sizing of dialog in favor of CSS#28134
Merged
Replace JS centering and sizing of dialog in favor of CSS#28134
Conversation
lordelix
requested review from
MorrisJobke and
SergioBertolinSG
and removed request for
MorrisJobke
Contributor
|
Works 👍 |
Contributor
Author
Contributor
|
regression: #29459 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the faulty and legacy JS code for centering and sizing the oc-dialog modals and replace it with modern CSS code.
Related Issue
Fixes https://github.com/owncloud/enterprise/issues/2063
How Has This Been Tested?
Only visual tests in latest Firefox and Google Chrome
Types of changes
Checklist:
FYI: @haukman