Skip to content

fix: Don't post data if no arguments were passed. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbeuque74 merged 2 commits into from
Mar 14, 2022
Merged

fix: Don't post data if no arguments were passed. #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cfac4b
fix: Don't post data if no arguments were passed.
amartinunowhy Jan 10, 2020
2b1cde9
fix(call): do not send body for POST/PUT operations when none were pr…
rbeuque74 Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ovh/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ def put(self, _target, _need_auth=True, **kwargs):
the default
"""
kwargs = self._canonicalize_kwargs(kwargs)
if not kwargs:
kwargs = None
return self.call('PUT', _target, kwargs, _need_auth)

def post(self, _target, _need_auth=True, **kwargs):
Expand All @@ -370,6 +372,8 @@ def post(self, _target, _need_auth=True, **kwargs):
the default
"""
kwargs = self._canonicalize_kwargs(kwargs)
if not kwargs:
kwargs = None
return self.call('POST', _target, kwargs, _need_auth)

def delete(self, _target, _need_auth=True, **kwargs):
Expand Down
12 changes: 12 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,12 @@ def test_post(self, m_call):
self.assertEqual(m_call.return_value, api.post(FAKE_URL, **PAYLOAD))
m_call.assert_called_once_with('POST', FAKE_URL, PAYLOAD, True)

@mock.patch.object(Client, 'call')
def test_post_no_body(self, m_call):
api = Client(ENDPOINT, APPLICATION_KEY, APPLICATION_SECRET, CONSUMER_KEY)
self.assertEqual(m_call.return_value, api.post(FAKE_URL))
m_call.assert_called_once_with('POST', FAKE_URL, None, True)

@mock.patch.object(Client, 'call')
def test_put(self, m_call):
PAYLOAD = {
Expand All @@ -258,6 +264,12 @@ def test_put(self, m_call):
self.assertEqual(m_call.return_value, api.put(FAKE_URL, **PAYLOAD))
m_call.assert_called_once_with('PUT', FAKE_URL, PAYLOAD, True)

@mock.patch.object(Client, 'call')
def test_put_no_body(self, m_call):
api = Client(ENDPOINT, APPLICATION_KEY, APPLICATION_SECRET, CONSUMER_KEY)
self.assertEqual(m_call.return_value, api.put(FAKE_URL))
m_call.assert_called_once_with('PUT', FAKE_URL, None, True)

## test core function

@mock.patch('ovh.client.Session.request')
Expand Down