Merged
Conversation
arnaudmorin
approved these changes
Apr 7, 2018
rbeuque74
requested changes
Apr 7, 2018
ovh/client.py
Outdated
| #: Mapping between OVH API region names and corresponding endpoints | ||
| ENDPOINTS = { | ||
| 'ovh-eu': 'https://eu.api.ovh.com/1.0', | ||
| 'ovh-us': 'https://api.ovh.us/1.0', |
Member
There was a problem hiding this comment.
URL is incorrect. Official URL for OVH US API is https://api.ovhcloud.com/1.0
rbeuque74
reviewed
Apr 7, 2018
Member
rbeuque74
left a comment
rbeuque74
left a comment
There was a problem hiding this comment.
Missing OVH US information on README.rst
jlejeune
approved these changes
Apr 14, 2018
rbeuque74
requested changes
Apr 14, 2018
Member
rbeuque74
left a comment
rbeuque74
left a comment
There was a problem hiding this comment.
Please update the README.rst to add links about
Documentation
Console
Create application credentials
Create script credentials (all keys at once)
Then we will be able to merge it :)
Member
|
Can you please sign your commits, as per the contribution guidelines? |
Alkorin
approved these changes
May 16, 2018
README.rst
Outdated
|
|
||
|
|
||
| - **Documentation**: https://api.ovhcloud.com/ | ||
| - **Community support**: api-subscribe@ml.ovh.net |
Member
There was a problem hiding this comment.
Indeed, this has to be removed
rbeuque74
requested changes
May 16, 2018
Member
rbeuque74
left a comment
rbeuque74
left a comment
There was a problem hiding this comment.
This pull-request still doesn't respect contributing guidelines: https://github.com/ovh/python-ovh/blob/master/CONTRIBUTING.rst
4. your work must be signed
Add the us endpoint Signed-off-by: Quentin GROLLEAU <quentin.grolleau@corp.ovh.com>
Signed-off-by: Quentin GROLLEAU <quentin.grolleau@corp.ovh.com>
Signed-off-by: Quentin GROLLEAU <quentin.grolleau@corp.ovh.com>
Signed-off-by: Romain Beuque <romain.beuque@corp.ovh.com>
geoffreybauduin
approved these changes
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the us endpoint