Open
Conversation
![github-advanced-security[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
suzp1984
force-pushed
the
feature/support-external-redis-srs
branch
2 times, most recently
from
bd1ade4 to
d18fa2b
Compare
suzp1984
force-pushed
the
feature/support-external-redis-srs
branch
from
d18fa2b to
a70f688
Compare
suzp1984
force-pushed
the
feature/support-external-redis-srs
branch
from
a70f688 to
0da4e53
Compare
suzp1984
force-pushed
the
feature/support-external-redis-srs
branch
2 times, most recently
from
0d5748c to
6eae8fe
Compare
winlinvip
reviewed
May 25, 2025
| return errors.Wrapf(err, "create file %v error", tsfile) | ||
| } else { | ||
| defer file.Close() | ||
| io.Copy(file, bytes.NewReader(data)) |
Member
There was a problem hiding this comment.
Should revert this, because not related to external redis service.
Contributor
Author
There was a problem hiding this comment.
The external Redis support already supported and commit by #196, this PR was all about external SRS.
winlinvip
reviewed
May 25, 2025
| res, err := http.DefaultClient.Get(api) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "reload srs %v", api) | ||
| logger.Tf(ctx, "srs api reload error %v", err) |
Member
There was a problem hiding this comment.
Should revert it, for not relevant to external redis.
winlinvip
reviewed
May 25, 2025
|
|
||
| // below stupied code is used to resolve the code scanning error: | ||
| // Uncontrolled data used in path expression | ||
| allowedDir, err := os.Getwd() |
Member
There was a problem hiding this comment.
Should revert it for not relevant to external redis.
Member
|
One PR should only fix one issue or support one feature. |
suzp1984
force-pushed
the
feature/support-external-redis-srs
branch
from
6eae8fe to
734639a
Compare
suzp1984
changed the title
suzp1984
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let Oryx can config external
Redis andSRS host.redis and srshost by env;external Redis support already supported and commit by #196, the initial comments here was so wrong.
Background
The requirement of let oryx to support external SRS was came from a k8s deployment ideas, let oryx, srs, redis run in different containers.
@see ossrs/srs-helm#8
The impact for the oryx is the record HLS ts file related features, which need to change the HLS ts segment file recording from disk file copy to http request, because oryx and srs may not share same disk.