Skip to content

- folder name option added for DiskLogAdapter.#224

Open
ummarbhutta wants to merge 5 commits intoorhanobut:masterfrom
ummarbhutta:master
Open

- folder name option added for DiskLogAdapter.#224
ummarbhutta wants to merge 5 commits intoorhanobut:masterfrom
ummarbhutta:master

Conversation

@ummarbhutta
Copy link

  • max file size option added for DiskLogAdapter.
  • packages updated

- max file size option added for DiskLogAdapter.
- packages updated
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Guiorgy and others added 3 commits February 11, 2019 15:57
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
@Guiorgy
Copy link

Guiorgy commented Feb 11, 2019

also, change buildToolsVersion = '27.0.3' to buildToolsVersion = '28.0.3' in logger/build.gradle (in the root folder)

@ummarbhutta
Copy link
Author

@Guiorgy The buildToolsVersion is already 28.0.3

@Guiorgy
Copy link

Guiorgy commented Feb 11, 2019

@Guiorgy The buildToolsVersion is already 28.0.3

You replaced a global variable (rootProject.ext.buildToolsVersion) with a constant (28.0.3) in multiple files. I am just saying, that you should revert them back and change the variable value instead.

@ummarbhutta
Copy link
Author

Hello @Guiorgy

Thanks for suggestions and I accepted your suggestions and committed.

@nikitph
Copy link

nikitph commented Mar 8, 2021

can someone please merge this. we need this for a project

@lupaulus
Copy link

lupaulus commented Sep 16, 2021

I forked and updated the project : Forked Project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments