- folder name option added for DiskLogAdapter.#224
Open
ummarbhutta wants to merge 5 commits intoorhanobut:masterfrom
Open
- folder name option added for DiskLogAdapter.#224ummarbhutta wants to merge 5 commits intoorhanobut:masterfrom
ummarbhutta wants to merge 5 commits intoorhanobut:masterfrom
Conversation
ummarbhutta
commented
Jan 10, 2019
- max file size option added for DiskLogAdapter.
- packages updated
- max file size option added for DiskLogAdapter. - packages updated
Guiorgy
reviewed
Feb 11, 2019
Guiorgy
reviewed
Feb 11, 2019
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Guiorgy
suggested changes
Feb 11, 2019
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
|
also, change |
Author
|
@Guiorgy The buildToolsVersion is already 28.0.3 |
You replaced a global variable ( |
Author
|
Hello @Guiorgy Thanks for suggestions and I accepted your suggestions and committed. |
rasoulmiri
approved these changes
Nov 16, 2019
Hightower87
approved these changes
Feb 11, 2020
|
can someone please merge this. we need this for a project |
|
I forked and updated the project : Forked Project |
misha1528
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.