WIP security/maltrail: new plugin#1241
Closed
mimugmail wants to merge 11 commits intoopnsense:masterfrom
mimugmail:mt
Closed
WIP security/maltrail: new plugin#1241mimugmail wants to merge 11 commits intoopnsense:masterfrom mimugmail:mt
mimugmail wants to merge 11 commits intoopnsense:masterfrom
mimugmail:mt
Conversation
fichtner
reviewed
Mar 11, 2019
| @@ -0,0 +1,3 @@ | |||
| maltrailsensor:/etc/rc.conf.d/opnsense-maltrailsensor | |||
Member
There was a problem hiding this comment.
here's your error:
Suggested change
| maltrailsensor:/etc/rc.conf.d/opnsense-maltrailsensor | |
| maltrailsensor.conf:/etc/rc.conf.d/opnsense-maltrailsensor |
fichtner
reviewed
Mar 11, 2019
| @@ -0,0 +1,3 @@ | |||
| maltrailsensor:/etc/rc.conf.d/opnsense-maltrailsensor | |||
| maltrailserver:/etc/rc.conf.d/opnsense-maltrailserver | |||
Member
There was a problem hiding this comment.
and here:
Suggested change
| maltrailserver:/etc/rc.conf.d/opnsense-maltrailserver | |
| maltrailserver.conf:/etc/rc.conf.d/opnsense-maltrailserver |
Member
|
although it would be better to rename the rc.conf files to avoid the ".conf" suffix, it's a bit misleading |
Member
Author
|
I always thought I brought my c+p skills to perfection :) You made my day, thx 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
new plugin, consists of 2 services, server and sensor. You can run on one system both, or just central server or a sensor sending logs to a server.
Form/Model seems to be ok, but I get a configd error and therefore config file doesn't get touched:
Server start/stop also works see for me it seems it should work in general, but I have no idea why this comes:
TemplateNotFound: OPNsense/Maltrail/maltrailserverPlease don't review other stuff, it's not yet finished