Merged
Conversation
Contributor
Author
|
and find_package(Iconv) is broken again. What a surprise... |
neheb
force-pushed
the
7
branch
2 times, most recently
from
7d3bf78 to
38bcf2f
Compare
Contributor
Author
|
Added a basic meson build. Took care to match the cmake build. |
Contributor
Author
|
@dhewg does PKG_INSTALL do anything with meson packages? |
Closed
Switch to cmake. Add upstream patch fixing iconv detection. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
Author
|
@paulfertser updated based on upstream feedback. |
Contributor
I don't think so. Looking at it again: It's inconsistent, may be that could be cleaned up. But I don't recall if there was a specific reason to not go the cmake route. |
Contributor
Author
|
Yeah I removed it: df5d724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to cmake.
Signed-off-by: Rosen Penev rosenp@gmail.com
Maintainer: @paulfertser
Compile tested: mips24