UCS/SYS: prevent huge pages allocation when IPC_CAP_LOCK not present or no reserved huge pages #11084
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or no reserved huge pages
yosefe
previously approved these changes
Dec 25, 2025
yosefe
reviewed
Dec 25, 2025
| huge_page_size = ucs_get_huge_page_size(); | ||
| if (huge_page_size <= 0) { | ||
| if ((huge_page_size <= 0) || (ucs_get_huge_pages_count() <= 0) || | ||
| !ucs_sys_get_mlock_cap()) { |
Contributor
There was a problem hiding this comment.
minor: pls adjust the debug message to write "SHM_HUGETLB is not supported on the system" because CAP_IPC_LOCK absence is specifically disabling SHM_HUGETLB
yosefe
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent huge pages allocation when IPC_CAP_LOCK not present or no reserved huge pages
Why?
Disable kernel warning about deprecated mem lock mechanism
solves issue: #10952