UCT/CUDA: add rkey_ptr flag to cuda_ipc component #11069
+42
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
reviewed
Dec 18, 2025
yosefe
reviewed
Dec 21, 2025
|
|
||
| /* For non-CPU receive memory types, avoid selecting the rkey_ptr mtype | ||
| * pipeline. It relies on obtaining a host pointer and CPU-side copy. */ | ||
| if (!UCP_MEM_IS_ACCESSIBLE_FROM_CPU(init_params->select_param->mem_type)) { |
Contributor
There was a problem hiding this comment.
Seems weird since rndv_rkey_ptr_mtype should support local/remote cuda buffers.
can we do this inside the code that search for rkey_ptr lane in ucp_proto_common_find_lanes ? by adjusting the filter callback (ucp_proto_common_filter_min_frag) to filter out lanes according to some mask of rkey_ptr_mem_types that is set by the protocol.
Contributor
|
The test failure seems relevant: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add UCT_COMPONENT_FLAG_RKEY_PTR to cuda_ipc component. With this flag ucp_rkey_ptr can use cuda_ipc