Skip to content

fix: Fixed MCP tools return issue with mcp sdk changes#808

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
samanthajayasinghe:fix-mcp-return
Oct 20, 2025
Merged

fix: Fixed MCP tools return issue with mcp sdk changes#808
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
samanthajayasinghe:fix-mcp-return

Conversation

@samanthajayasinghe
Copy link
Contributor

Fixed MCP tools return issue with mcp sdk changes

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

  • Related Issue #
  • Closes #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 20, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 35.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.83%. Comparing base (e188235) to head (33ca494).

Files with missing lines Patch % Lines
pkg/ai/mcp/backplane_console.go 7.69% 24 Missing ⚠️
pkg/ai/mcp/backplane_cloud_console.go 47.82% 11 Missing and 1 partial ⚠️
cmd/ocm-backplane/mcp/mcp.go 0.00% 2 Missing ⚠️
pkg/ai/mcp/backplane_cluster_resource.go 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   52.85%   52.83%   -0.03%     
==========================================
  Files          86       86              
  Lines        6421     6420       -1     
==========================================
- Hits         3394     3392       -2     
- Misses       2575     2577       +2     
+ Partials      452      451       -1     
Files with missing lines Coverage Δ
pkg/ai/mcp/backplane_login.go 100.00% <100.00%> (ø)
pkg/ai/mcp/backplane_cluster_resource.go 42.10% <80.00%> (ø)
cmd/ocm-backplane/mcp/mcp.go 6.52% <0.00%> (ø)
pkg/ai/mcp/backplane_cloud_console.go 53.19% <47.82%> (+4.97%) ⬆️
pkg/ai/mcp/backplane_console.go 18.18% <7.69%> (-4.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaoyu74
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samanthajayasinghe, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [samanthajayasinghe,xiaoyu74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2a2d023 into openshift:main Oct 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants