Skip to content
This repository was archived by the owner on Sep 4, 2023. It is now read-only.

[SRVKS-452] Bump webhook memory limit to 1G.#7

Merged
markusthoemmes merged 1 commit intoopenshift-knative:release-0.13from
markusthoemmes:bump-webhook-limits
Mar 13, 2020
Merged

[SRVKS-452] Bump webhook memory limit to 1G.#7
markusthoemmes merged 1 commit intoopenshift-knative:release-0.13from
markusthoemmes:bump-webhook-limits

Conversation

@markusthoemmes
Copy link

The linked JIRA has all the context. Unfortunately our webhook currently scales fairly linearly with namespaces so this would in theory allow ~1000 namespaces which sounds sufficient to me for the time being.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markusthoemmes
To complete the pull request process, please assign jcrossley3
You can assign the PR to them by writing /assign @jcrossley3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes markusthoemmes merged commit 36ecf1b into openshift-knative:release-0.13 Mar 13, 2020
@matzew
Copy link
Member

matzew commented Apr 7, 2020

@aliok can you apply the same change to eventing-operator

@jcrossley3
Copy link

I don't approve of this "fix". The right way to address this is in the CR itself, set by our knative-openshift operator, using this mechanism: knative#362

@markusthoemmes
Copy link
Author

@jcrossley3 I agree, when the fix was done this hasn't been merged yet. The resources override is also not in the 0.13 version. Please feel free to backport that into 0.13 and make the necessary changes in the serverless-operator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants