Skip to content

Conversation

@stee-re
Copy link
Collaborator

@stee-re stee-re commented Jul 11, 2025

Explaination of change

  • plugin-api.md > plugin details, was missing the editor property, so I added it.
  • The oscd-api has types for the Transactor & Edit(s), but the primary interface at the heart of this API is what properties are sent to every plugin. Although there is no way to constrain plugin instanciation to match this interface, it can offer some typing to functions responsible for instancating the plugins. I would also weive it into some plugin tests to make sure plugins get everything defined on the interface.
  • prettier integration into eslint was half baked, now its crispy
  • added in the change from "docVersion" to docsState" assuming no push-back, its cheaper to just get it in now and accept the low risk of having to back track later (as its not used yet)

@stee-re stee-re requested a review from ca-d July 11, 2025 10:57
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ca-d ca-d merged commit ad9a3d0 into openscd:main Jul 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants