Update admin/mkassoc to enable to work

[serihiro]

What will this pr change ?

• Enable to work admin/mkassoc.
  • When I tried to use this script with the newest version of ruby-openid, errors occurred for some interface mismatch.

[tobiashm]

👍

[tobiashm]

Why have you removed the URI.parse call?
I would guess that it's there to ensure that the arguments are valid URIs?

[serihiro]

@tobiashm
Thank you for your comment!

If OpenID::Consumer::AssociationManager#get_association with @server_url of URI object is called, bad URI error occured like the following:

$ ruby --version
ruby 2.3.3p222 (2016-11-21 revision 56859) [x86_64-darwin16]

$ bundle exec ruby admin/mkassoc http://auth.livedoor.com/openid/server
==================================================
Server: http://auth.livedoor.com/openid/server
/Users/seri/Documents/ruby-work/ruby-openid/lib/openid/kvpost.rb:54:in `rescue in make_kv_post': Unable to contact OpenID server: bad URI(is not URI?): http://
auth.livedoor.com/openid/server (OpenID::KVPostNetworkError)
        from /Users/seri/Documents/ruby-work/ruby-openid/lib/openid/kvpost.rb:51:in `make_kv_post'
        from /Users/seri/Documents/ruby-work/ruby-openid/lib/openid/consumer/associationmanager.rb:195:in `request_association'
        from /Users/seri/Documents/ruby-work/ruby-openid/lib/openid/consumer/associationmanager.rb:130:in `negotiate_association'
        from /Users/seri/Documents/ruby-work/ruby-openid/lib/openid/consumer/associationmanager.rb:118:in `get_association'
        from admin/mkassoc:11:in `block in <main>'
        from admin/mkassoc:7:in `each'
        from admin/mkassoc:7:in `<main>

This is because URI.parse is called twice, 1st time is here, and second time is here.

So, if you want to validate server_url in admin/mkassoc, how about adding this?

ARGV.each do |server_url|
  unless URI::regexp =~ server_url
    puts "`#{server_url}` will be skipped for invalid URI format."
    next
  end
  ...

end

[tobiashm]

Really like your last suggestion for validation.
Could you add that? Then I'll merge this.

[tobiashm]

Looking into the Travis CI build failure, which doesn't seem to have anything to do with this code.

[serihiro]

@tobiashm
I added validation and squashed into 6bcd3d0 . Please check this 🙇

[tobiashm]

@serihiro thank you

[serihiro]

Thank you for your merging! 🍻