Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 5, 2025

Description

We've changed the color of the avatars in the group settings within the admin setting to keep it consistent across the web ui

image

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the group avatar appearance in admin settings by replacing the legacy avatar component with the new OcAvatar component and updating related snapshots.

  • Replaces and its stub with in both the GroupInfoBox and GroupsList components.
  • Updates the snapshot file to reflect the new avatar markup and adjusts import ordering in GroupsList.vue.
Comments suppressed due to low confidence (2)

packages/web-app-admin-settings/src/components/Groups/SideBar/GroupInfoBox.vue:3

  • Confirm that using a literal attribute 'background-color' is intended and matches the prop expected by OcAvatar. Consider binding the property if a dynamic value is needed in the future.
<OcAvatar class="oc-mb-m" :width="80" :userid="group.id" :user-name="group.displayName" background-color="var(--oc-role-secondary)" />

packages/web-app-admin-settings/src/components/Groups/GroupsList.vue:119

  • [nitpick] The ordering and grouping of Vue imports have changed; ensure that they follow the project style guidelines for consistency.
nextTick,

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

@kulmann kulmann merged commit 6720ab4 into main Jun 6, 2025
19 checks passed
@kulmann kulmann deleted the admin-settings-group-avatars branch June 6, 2025 09:23
@openclouders openclouders mentioned this pull request Jun 6, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants