Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear requested review from Copilot and kulmann June 2, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the initialization issue of the space quota in the QuotaModal component.

  • Removed the onMounted lifecycle hook and now assigns the initial quota value directly.
  • Reordered composable imports for consistency.
Comments suppressed due to low confidence (1)

packages/web-pkg/src/components/Spaces/QuotaModal.vue:182

  • Removing the onMounted hook may cause the assignment to 'selectedOption' to occur before 'props.spaces' is fully initialized. Consider reintroducing onMounted to ensure that the quota is set after the component is mounted.
selectedOption.value = props.spaces[0]?.spaceQuota?.total || 0

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special thank you for the script setup changes 🥇

@AlexAndBear AlexAndBear merged commit ed964f6 into main Jun 3, 2025
18 checks passed
@AlexAndBear AlexAndBear deleted the fix/561 branch June 3, 2025 08:23
@openclouders openclouders mentioned this pull request Jun 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting custom space quota results in displaying no restrictions

3 participants