-
Notifications
You must be signed in to change notification settings - Fork 24
fix(admin-settings): broken update user space quota for users with sp… #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-settings): broken update user space quota for users with sp… #774
Conversation
…ecial characters in name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the issue of updating a user's space quota when their username contains special characters by switching to the correct update interface.
- Updated the type for the updateDrive function from Drive to DriveUpdate in the web-client.
- Removed the unnecessary and problematic drive name from the update payload in the admin settings EditPanel.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-client/src/graph/drives/types.ts | Updated import and argument type for updateDrive to use DriveUpdate, ensuring proper request payload formation. |
| packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue | Removed the drive name from the update call, resolving payload issues with special characters. |
Comments suppressed due to low confidence (2)
packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue:232
- Removing the drive name from the update payload corrects the usage of the updateDrive interface; verify that no dependent logic still relies on the drive name in this context.
name: editUser.drive.name,
packages/web-client/src/graph/drives/types.ts:18
- Confirm that the DriveUpdate interface includes all necessary fields required for the updateDrive operation to ensure data integrity.
data: DriveUpdate,
|
@AlexAndBear please have a look, its not clear to me if |
|
Totally fine here, we only update the quota if it comes down to drives in this view. |
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…ecial characters in name
Description
Under certain circumstances, it was not possible to change the user space quota. For example, it failed if the username contained special characters...
The error occurred because Web had always sent the username when changing the quota... In the end, it all comes down to the fact that the wrong interface was used in the client, which required a name
Related Issue
How Has This Been Tested?
Types of changes