feat: polish account page design #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR polishes the account page design by updating table layouts and component styles, improving consistency across the account-related components.
- Updated snapshot files to include explicit colgroup definitions for table column widths.
- Modified the AppTokens component to adjust button styling and table layout.
- Refactored the AccountTable component with a new responsive design for column widths.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-runtime/tests/unit/pages/snapshots/account.spec.ts.snap | Added colgroup elements to define table column widths. |
| packages/web-runtime/src/components/Account/AppTokens.vue | Updated table styling, button appearance, and icon size; removed scoped styling from the style block. |
| packages/web-runtime/src/components/Account/AccountTable.vue | Introduced colgroup and responsive media query adjustments for table columns. |
Comments suppressed due to low confidence (1)
packages/web-runtime/src/components/Account/AppTokens.vue:49
- The removal of the tooltip directive and associated aria-label may impact accessibility. Consider retaining or replacing these attributes to ensure the button remains accessible.
v-oc-tooltip="$gettext('Delete app token')"
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| <style lang="scss"> |
There was a problem hiding this comment.
The removal of the scoped attribute from the style block in the AppTokens component may lead to unintended global style side effects. Consider adding a comment explaining the rationale behind this change or reintroducing scoping if isolated styling is desired.
Suggested change
| <style lang="scss"> | |
| <style lang="scss" scoped> |
JammingBen
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes