Skip to content

Conversation

@fschade
Copy link
Contributor

@fschade fschade commented May 15, 2025

Description

Implements the functionality described in opencloud-eu/opencloud#732, which focuses on the ability to add custom profile pictures.

** MS-Graph API **

Related Issue

Motivation and Context

allow users to upload and manage their profile pictures

How Has This Been Tested?

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Todo:

dragonchaser and others added 8 commits May 20, 2025 15:10
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@fschade fschade force-pushed the add-profile-photo branch 2 times, most recently from 5fa9000 to 478fd1a Compare May 20, 2025 13:35
@fschade fschade force-pushed the add-profile-photo branch from 478fd1a to 2504006 Compare May 20, 2025 14:09
@fschade fschade marked this pull request as ready for review May 20, 2025 14:09
@fschade
Copy link
Contributor Author

fschade commented May 20, 2025

@AlexAndBear please check if ok for you

@AlexAndBear
Copy link
Contributor

@AlexAndBear please check if ok for you

Ok for me

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the endpoint named $value? That's awful to debug.

Screenshot 2025-05-22 at 15 49 39

@fschade
Copy link
Contributor Author

fschade commented May 22, 2025

Why is the endpoint named $value? That's awful to debug.

Screenshot 2025-05-22 at 15 49 39

I asked myself the same thing, MS probably thinks it's a nice idea... without words...

GET /me/photo/$value
GET /users/{id | userPrincipalName}/photo/$value
GET /groups/{id}/photo/$value
GET /me/contacts/{id}/photo/$value
GET /users/{id | userPrincipalName}/contacts/{id}/photo/$value
GET /me/contactfolders/{contactFolderId}/contacts/{id}/photo/$value
GET /users/{id | userPrincipalName}/contactfolders/{contactFolderId}/contacts/{id}/photo/$value
GET /team/{id}/photo/$value

because the "top"-level enpoints reserved for the meta data...

GET /me/photo
GET /me/photos
GET /users/{id | userPrincipalName}/photo
GET /groups/{id}/photo
GET /me/contacts/{id}/photo
GET /users/{id | userPrincipalName}/contacts/{id}/photo
GET /me/contactfolders/{contactFolderId}/contacts/{id}/photo
GET /users/{id | userPrincipalName}/contactfolders/{contactFolderId}/contacts/{id}/photo
GET /team/{id}/photo

https://learn.microsoft.com/en-us/graph/api/profilephoto-get?view=graph-rest-1.0&tabs=http

@fschade
Copy link
Contributor Author

fschade commented May 26, 2025

@fschade fschade merged commit db7d053 into opencloud-eu:main May 26, 2025
51 checks passed
@openclouders openclouders mentioned this pull request May 26, 2025
1 task
@dragonchaser dragonchaser deleted the add-profile-photo branch May 26, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server] persist user profile pictures

5 participants