Use shortcut components from appkit and adjust display of tab and shift keys #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used in Tobira as well, so we moved the code to appkit.
This is to get in line with our decision on how to display these keys. Tobira also does it like that now.
owi92
approved these changes
Aug 22, 2025
Contributor
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Code looks reasonable and still works.
Comment on lines
+188
to
+191
| const key = groupId as keyof typeof SHORTCUTS; | ||
| const shortcuts = Object.entries(group).map(([name, keys]) => ({ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| label: t((SHORTCUT_TRANSLATIONS[key] as any)[name]), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Ye I looked briefly into it but couldn't find a solution quickly :/ its annoying and I don't understand it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.
Deployed: https://test.studio.opencast.org/2025-08-22_12-29-16-pr1264-17155270820/