Add ability to specify ACL in a concise way #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @LukasKalbertodt, |
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
LukasKalbertodt
force-pushed
the
concise-acl
branch
from
df2a860 to
1db0f7b
Compare
github-actions
bot
removed
the
status:conflicts
|
Thanks for this improvements! We did test this PR successfully with the integration in the ILIAS Opencast plugin. Rights were granted in Opencast to the OC Studio recordings as expected. |
|
This pull request has conflicts ☹ |
github-actions
bot
added
the
status:conflicts
Before, it was tricky to even test having a settings file in dev mode. But we don't want to include it in production mode (though this is not really a problem anymore since we use CI to build production builds, where the settings.toml is never present).
LukasKalbertodt
force-pushed
the
concise-acl
branch
from
1db0f7b to
c6648c0
Compare
github-actions
bot
removed
the
status:conflicts
Before, one had to always specify an XML blob, which is suuuper verbose. With this, Studio also allows a more concise representation that's also suitable to be included in the URL. While each string in the object is also treated as a mustache template, with the object notation, it is not possible to conditionally add entries. At least not yet.
LukasKalbertodt
force-pushed
the
concise-acl
branch
from
c6648c0 to
ad022d9
Compare
Member
Author
|
Bern tested this and @ferishili did a quick review, so this is ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, one had to always specify an XML blob, which is suuuper verbose.
With this, Studio also allows a more concise representation that's also
suitable to be included in the URL. While each string in the object is
also treated as a mustache template, with the object notation, it is not
possible to conditionally add entries. At least not yet.
@ferishili you asked for this, could you take a look and tell me if it fully solves your use case?