Fix review step on iOS #1132
Merged
Fix review step on iOS #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It worked in other browsers only by coincidence. I assume that pausing the video in other browsers always causes a last `timeupdate`, which lead to a rerender. On Safari this doesn't happen, so we have to make sure that pausing/playing the video actually causes a rerender.
LukasKalbertodt
force-pushed
the
fix-ios
branch
from
b41fc5b to
af44c8a
Compare
Arnei
approved these changes
Oct 5, 2023
Member
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
// For iOS: without the autoplay attribute, the
loadeddataevent is
// never fired for some reason. Adding this does not seem to actually
// cause Safari to autoplay.
Haha iOS you so funny.
Looks good and works as expected. Tested with iOS 17.0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1076
See commits.