Skip to content

Enable request_user_input in Default mode#12735

Merged
charley-oai merged 16 commits intomainfrom
collaboration-modes-config
Feb 25, 2026
Merged

Enable request_user_input in Default mode#12735
charley-oai merged 16 commits intomainfrom
collaboration-modes-config

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Feb 25, 2026

Summary

  • allow request_user_input in Default collaboration mode as well as Plan
  • update the Default-mode instructions to prefer assumptions first and use request_user_input only when a question is unavoidable
  • update request_user_input and app-server tests to match the new Default-mode behavior
  • refactor collaboration-mode availability plumbing into CollaborationModesConfig for future mode-related flags

Codex author

codex resume 019c9124-ed28-7c13-96c6-b916b1c97d49

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pub reasoning_effort: Option<Option<ReasoningEffort>>,
#[serde(rename = "developer_instructions")]
#[ts(rename = "developer_instructions")]
#[deprecated(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it deprecated or just use it to override instructions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just remove the field. This type is only used for the return type of the list endpoint, not params of any other endpoints

@charley-oai charley-oai force-pushed the collaboration-modes-config branch from 0199239 to d6d0dfc Compare February 25, 2026 21:58
@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6d0dfc5ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcac11bb28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit 2f4d6de into main Feb 25, 2026
28 of 33 checks passed
@charley-oai charley-oai deleted the collaboration-modes-config branch February 25, 2026 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants