fix(tui): flush input buffer on init to prevent early exit on Windows#10729
Merged
etraut-openai merged 1 commit intoopenai:mainfrom Feb 5, 2026
Merged
Conversation
Collaborator
|
@codex review |
etraut-openai
requested changes
Feb 5, 2026
Collaborator
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Thanks for the PR. Let's keep it targeted to just the input buffer flush.
Contributor
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
|
You can ignore the fact that the Bazel builds are failing. |
Ashutosh0x
force-pushed
the
fix/windows-tui-login-early-exit-10661
branch
from
335f040 to
b543f12
Compare
Ashutosh0x
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10661.
Problem
On Windows, the sign-in menu can exit immediately if the OS-level input buffer contains trailing characters (like the Enter key from running the command).
Solution
Flush Input Buffer on Init: Use FlushConsoleInputBuffer on Windows (and cflush on Unix) in ui::init() to discard any input captured before the TUI was ready.
Verified by @CodebyAmbrose in #10661.