import packaging to be compatible with setuptools==70.0.0#449
Merged
jongwook merged 2 commits intoopenai:mainfrom Jun 4, 2024
Merged
import packaging to be compatible with setuptools==70.0.0#449jongwook merged 2 commits intoopenai:mainfrom
jongwook merged 2 commits intoopenai:mainfrom
Conversation
This was referenced Jun 3, 2024
Contributor
Author
|
The above run failed because it's using setuptools version setuptools-69.5.1, yet the comment states that this approach REQUIRES setuptools 70.0.0 to be used. It may be better to use #450 instead if backward compatibility is desired. If so, please feel free to close this PR. |
Collaborator
|
Thanks again for your contribution -- I prefer this PR because it's simpler, and it appears that with |
denis-ismailaj
pushed a commit
to denis-ismailaj/CLIP
that referenced
this pull request
Jul 8, 2024
* import packaging to be compatible with setuptools==70.0.0 * importing the version module --------- Co-authored-by: Jamie <Jamie@Alexandras-MacBook-Pro.local> Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in Issue #446 (#446), there is a change from setuptools 70.0.0 which causes breaking behaviour. This change fixes this. However, it will force the usage of setuptools 70.0.0.
In another PR, I've offered a solution which checks the version, which provides backward compatibility - #450