Filter out system threads in AgentRunner to prevent internal events f… #186
Conversation
…rom being processed as agent prompts, enhancing conversation thread management.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR enhances conversation thread management in the AgentRunner by filtering out system threads (those with IDs starting with "thread:system") before creating the EventContext passed to agent's react method. This prevents internal system events and logs from being included in the conversation context that agents use to generate responses.
Key changes:
- Added filtering logic to exclude system threads when building the filtered_threads dictionary
- Added explanatory comments documenting that system threads contain internal events/logs not intended for agent prompts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Skip system threads - they contain internal events and logs, not for agent prompts | ||
| if thread_id.startswith("thread:system"): | ||
| continue |
There was a problem hiding this comment.
The new system thread filtering logic lacks test coverage. Consider adding tests to verify that:
- Threads with IDs starting with "thread:system" are excluded from filtered_threads
- System thread messages are not included in the EventContext passed to the react method
- Non-system threads continue to be processed normally
This would ensure the filtering behaves correctly and prevent regressions.
…rom being processed as agent prompts, enhancing conversation thread management.