Setting to disable email notifications of comments

[AndrewKvalheim]

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the upstream master branch.
• The tests pass locally with my changes.
• I have added tests that prove my fix is effective or that my feature works (if appropriate).
• I have added necessary documentation (if appropriate).

Short description of what this resolves

SeaGL uses comments during a specific review process in which email notifications aren’t appropriate. Previously we’d simply disabled notifications by removing that code, but a runtime setting for this would be more convenient.

Changes proposed in this pull request

Add a new setting, defaulting to enabled:

• E-Mails → Proposal → Send an email to all organizers and CfP team members when a comment is added?

Concerns

• Is Proposal the right place to put this, or should there be a Comments tab?
• This was the simplest solution to implement, but it might be preferable to instead allow more fine-grained control over which roles get notified, or to expose separate notification settings to each user.

[hennevogel]

SeaGL uses comments heavily during a specific review process in which email notifications aren’t appropriate

Why? I mean comments are appropriate obviously, notifications are just helping people to not loose track. Can you explain?

[AndrewKvalheim]

It’s been tedious to get an explanation but I think the review process is:

1. Individually, each reviewer on their own time:
   1. For each proposal:
      1. Outside of OSEM, read a copy of only the title and abstract.
      2. Outside of OSEM, decide on a vote.
      3. Within OSEM, submit the vote and optionally comment to explain your decision.
2. Collectively, all reviewers in a meeting:
   1. For each proposal:
      1. Within OSEM, read the entire proposal, including its votes and comments.

The reviewers avoid exposure to comments until after they’ve decided on their vote, and active notifications of comments work against that goal.

[hennevogel]

The reviewers avoid exposure to comments until after they’ve decided on their vote, and active notifications of comments work against that goal.

We already have a setting for that "behavior". It's called Program.blind_voting. Instead of another configuration we should apply this to comments and sending emails about comments in Program.voting_period? too.