fix: do not panic on unexpected end of archive #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning from an archive which ends unexpectedly we now fail with an error instead of panicking. The panic previously occurred when the caller continued to read from the chunk stream after the first error. Now the stream is closed after the first error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning from an archive which ends unexpectedly we should no longer panic. The panic previously occurred when the caller continued to read from the chunk stream after the first error. Now the stream is closed after the first error.
This might fix #40 since ending up with a truncated archive seems like the most likely way to corrupt a file during a copy.