chore: Migrate from tslint to eslint

.eslintrc

@@ -1,3 +1,8 @@
 {
-  "extends": "oclif"
-}
+  "extends": [
+    "oclif",
+    "oclif-typescript"
+  ],
+  "rules": {
+  }
+}

package.json

@@ -18,18 +18,17 @@
   "devDependencies": {
     "@oclif/dev-cli": "^1",
     "@oclif/test": "^1",
-    "@oclif/tslint": "^3",
     "@types/axios": "^0.14.0",
     "@types/chai": "^4",
     "@types/mocha": "^5",
     "@types/node": "^10",
     "chai": "^4",
-    "eslint": "^5.13",
-    "eslint-config-oclif": "^3.1",
+    "eslint": "^6.6.0",
+    "eslint-config-oclif": "^3.1.0",
+    "eslint-config-oclif-typescript": "^0.1.0",
     "mocha": "^5",
     "nyc": "^13",
     "ts-node": "^8",
-    "tslint": "^5",
     "typescript": "^3.3"
   },
   "engines": {
@@ -63,14 +62,15 @@
   "scripts": {
     "build": "rm -rf lib && tsc",
     "clean": "rm -f .oclif.manifest.json",
-    "lint": "tsc -p test --noEmit && tslint -p test -t stylish",
+    "lint": "eslint . --ext .ts --config .eslintrc",
     "postpack": "rm -f oclif.manifest.json",
     "postpublish": "yarn run clean",
-    "posttest": "tslint -p test -t stylish",
     "prepack": "rm -rf lib && tsc -b && oclif-dev manifest && oclif-dev readme",
     "prepublishOnly": "yarn run build && oclif-dev manifest",
     "preversion": "yarn run clean",
+    "pretest": "tsc -p test --noEmit",
     "test": "nyc --extension .ts mocha --forbid-only \"test/**/*.test.ts\"",
+    "posttest": "yarn lint",
     "version": "oclif-dev readme && git add README.md"
   },
   "types": "lib/index.d.ts"

src/commands/stars.ts

@@ -3,11 +3,13 @@ import axios from 'axios'
 
 export default class Stars extends Command {
   static description = 'show the github stars on a repository'
+
   static args = [{name: 'repository', required: true}]
+
   async run() {
     const {args} = this.parse(Stars)
     const {data: stargazers} = await axios.get(`https://api.github.com/repos/${args.repository}/stargazers`)
-    for (let s of stargazers) {
+    for (const s of stargazers) {
       this.log(s.login)
     }
   }

test/commands/stars.test.ts

@@ -2,25 +2,25 @@ import {expect, test} from '@oclif/test'
 
 describe('stars', () => {
   test
-    .nock('https://api.github.com', api => {
-      api
-        .get('/repos/oclif/oclif/stargazers')
-        .reply(
-          () => ([
-            200,
-            [
-              {login: 'heroku'},
-              {login: 'oclif'},
-              {login: 'javascript'}
-            ]
-          ])
-        )
-    })
-    .stdout()
-    .command(['stars', 'oclif/oclif'])
-    .it('lists stargazers from repo', ctx => {
-      expect(ctx.stdout).to.contain('heroku')
-      expect(ctx.stdout).to.contain('oclif')
-      expect(ctx.stdout).to.contain('javascript')
-    })
+  .nock('https://api.github.com', api => {
+    api
+    .get('/repos/oclif/oclif/stargazers')
+    .reply(
+      () => ([
+        200,
+        [
+          {login: 'heroku'},
+          {login: 'oclif'},
+          {login: 'javascript'},
+        ],
+      ]),
+    )
+  })
+  .stdout()
+  .command(['stars', 'oclif/oclif'])
+  .it('lists stargazers from repo', ctx => {
+    expect(ctx.stdout).to.contain('heroku')
+    expect(ctx.stdout).to.contain('oclif')
+    expect(ctx.stdout).to.contain('javascript')
+  })
 })