Open
Conversation
El10 uses python 3.12. This python version removed alot of api's that had been deprecated since a while. - Add pyasyncore fallback for removed asyncore module - Replace deprecated distutils.spawn with shutil.which - Update SSL socket creation to use modern context API - Replace deprecated configparser.SafeConfigParser - Replace deprecated readfp() with read_file() - Add pyasyncore dependency for EL10 builds Signed-off-by: Peter Boden <peter.boden@team.blue>
Replace nose testing framework with pytest: - Replace nose specific env vars (`NOSE_*`) - Replace nose specific functions (assertions, skip tests,...) - Remove customizations that are no longer needed for pytest (logformat,verbosity...) - Remove VdsmTestResult & VdsmTestRunner because pytest already provides this or similar functionality out of the box. - Convert nose plugins to pytest plugins. - Don't run gluster test suite when gluster is enabled Signed-off-by: Peter Boden <peter.boden@team.blue>
- Upgrade pylint to >=3.2.0,<4.0.0 and remove deprecated config options - Replace deprecated ssl.wrap_socket with ssl.SSLContext for Python 3.12 - Fix variable scoping issues (E0601/E0606): initialize variables before conditional blocks in merge.py, resourceManager.py, vm.py, hsm.py, and gluster/api.py - Fix attribute access before definition (E0203) in asyncevent.py and betterAsyncore.py - Resolve import conflicts, a false positivie and flake8 style violations in vmdevices/storage.py - Add default case for unknown bonding modes in bond_speed.py Signed-off-by: Peter Boden <peter.boden@team.blue>
Upgrade flake8 because the old version was incompatible with newer python versions. Signed-off-by: Peter Boden <peter.boden@team.blue>
- Add a small sleep to make sure changes have propagated - Add automatic retry if network ip assert fails Signed-off-by: Peter Boden <peter.boden@team.blue>
Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
shubhaOracle
requested review from
aesteve-rh,
almusil,
mz-pdm and
tinez
as code owners
JasperB-TeamBlue
requested review from
JasperB-TeamBlue,
dupondje and
peter-boden
Member
|
@shubhaOracle : can you rebase? |
Contributor
Author
|
@dupondje Requesting review. |
dupondje
requested changes
Jan 26, 2026
lib/vdsm/aarch64HardwareInfo.py
Outdated
| sys_info[key]=value | ||
|
|
||
| except: | ||
| print("ERROR") |
lib/vdsm/validatehost.py
Outdated
|
|
||
| out = exec_validate_cmd(VIRT_HOST_VALIDATE_CMD) | ||
|
|
||
| if (not 'fail' in out.lower()) : |
Contributor
Author
There was a problem hiding this comment.
We need to verify that there are no failures are reported in the output
Member
There was a problem hiding this comment.
This is exactly what the exit code does?
Upon successful validation, an exit status of 0 will be set. Upon failure a non-zero status will be set.
Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
… into arm-vdsm-changes
Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
Signed-off-by: ShubhaOracle <Shubha.kulkarni@oracle.com>
Member
|
Please also rebase and squash the commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Add ARM support
Added virt validation and flag so that CPU model can be identified
Associated engine side changes are added to PR oVirt/ovirt-engine#1063
Signed-off-by: ShubhaOracle Shubha.kulkarni@oracle.com
Are you owner: yes