-
-
Notifications
You must be signed in to change notification settings - Fork 739
fix(module): work with route rules cache: true
#3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying content with Β
|
| Latest commit: |
f705a59
|
| Status: | Β β Β Deploy successful! |
| Preview URL: | https://eb6712c1.content-f0q.pages.dev |
| Branch Preview URL: | https://fix-nitro-cache.content-f0q.pages.dev |
commit: |
|
@maximepvrt This PR should resolve the issue, I would appreciate if you can verify using pr-release? π |
|
@farnabaz it's perfect for me ;-) Thanks ! |
|
@farnabaz but in this branch/pk.pr.new I have error with yml parcing if I active nitro cache
title: Γtre bΓ©nΓ©vole
name: Devenir bΓ©nΓ©vole
description: Vous souhaitez vivre une expΓ©rience utile et agrΓ©able par le bΓ©nΓ©volat ? bravo ! Peut-Γͺtre avez vous une idΓ©e trΓ¨s prΓ©cise de ce que vous souhaitez faire. Peut-Γͺtre moins. Nous sommes lΓ pour vous aider Γ vous y retrouver !
items:
- title: S'engager pour une cause
description: DΓ©couvrez les diffΓ©rents domaines dβactivitΓ©s des associations et choisissez
de faire du bΓ©nΓ©volat dans les causes qui vous tiennent le plus Γ coeur.
to: "/devenir-benevole/domaine"
image: "/devenir-benevole/domaine.svg"
- title: Agir localement
description: Les associations recherchent des bΓ©nΓ©voles partout en France. DΓ©couvrez
les missions de bΓ©nΓ©volat proposΓ©es par les associations locales !
to: "/devenir-benevole/france"
image: "/devenir-benevole/france.svg"
- title: Agir Γ tout Γ’ge
description: Que lβon soit Γ©tudiant, jeune actif, demandeur dβemploi, femme, homme,
retraitΓ©, diplΓ΄mΓ©, dΓ©crocheur, ou dans une toute autre situation, il y a toujours
une bonne raison de faire du bΓ©nΓ©volat.
to: "/devenir-benevole/profil"
image: "/devenir-benevole/profil.svg"
- title: Partager ses compΓ©tences
description: DΓ©couvrez les diffΓ©rentes activitΓ©s dans lesquelles vous pouvez faire
du bΓ©nΓ©volat et partagez votre expΓ©rience et votre Γ©nergie.
to: "/devenir-benevole/activite"
image: "/devenir-benevole/domaine.svg"
- title: Rejoindre une association nationale
description: Il existe forcΓ©ment une antenne locale d"une organisation nationale
près de chez vous.
to: "/reseau"
external: true
image: "/devenir-benevole/reseau.svg" |
|
@maximepvrt This is even stranger that original issue. Do you mind monkey patch and add a log here to show the error trace and find the line? Line 375 in 9ddbb10
Also may I have access to repo? is it public? |
|
@farnabaz I just sent you a DM on Discord regarding this. |
cache: true
β¦ config hook
π Linked issue
resolves #3613
β Type of change
π Description
This was an attempt to solve #3613. But it seems that it works only if we move route to
/api/**.Nitro cache + server handler on
modules:donehook does not work if it is not prefixed with/api/cc @pi0 @atinuxπ Checklist