fix(arborist): simplify rootDeclaredDeps initialization

[manzoorwanijk]

Summary

Simplifies the #rootDeclaredDeps initialization in isolated-reifier.js by using Object.assign instead of multiple Object.keys spread calls.

Suggested in #9095 (comment).

Before

this.#rootDeclaredDeps = new Set([
  ...Object.keys(rootPkg.dependencies || {}),
  ...(!omit.has('dev') ? Object.keys(rootPkg.devDependencies || {}) : []),
  ...(!omit.has('optional') ? Object.keys(rootPkg.optionalDependencies || {}) : []),
  ...(!omit.has('peer') ? Object.keys(rootPkg.peerDependencies || {}) : []),
])

After

this.#rootDeclaredDeps = new Set(Object.keys(Object.assign({},
  rootPkg.dependencies,
  (!omit.has('dev') && rootPkg.devDependencies),
  (!omit.has('optional') && rootPkg.optionalDependencies),
  (!omit.has('peer') && rootPkg.peerDependencies),
)))

[wraithgar]

chore is reserved for changes that would not be part of the published package. Things like workspace changes, changes to tests only, etc.

[manzoorwanijk]

chore is reserved for changes that would not be part of the published package. Things like workspace changes, changes to tests only, etc.

Noted. Thanks