Skip to content

fix: backport linked strategy fixes from multiple PRs to v10#9011

Merged
wraithgar merged 1 commit intonpm:release/v10from
manzoorwanijk:v10
Mar 4, 2026
Merged

fix: backport linked strategy fixes from multiple PRs to v10#9011
wraithgar merged 1 commit intonpm:release/v10from
manzoorwanijk:v10

Conversation

@manzoorwanijk
Copy link
Contributor

@manzoorwanijk manzoorwanijk commented Feb 23, 2026

@manzoorwanijk manzoorwanijk requested a review from a team as a code owner February 23, 2026 04:27
@manzoorwanijk manzoorwanijk changed the title [v10 backport] fix: linked strategy fixes for scoped packages, aliases, and peer deps [v10 backport] fix: linked strategy for scoped packages, aliases, and peer deps Feb 23, 2026
@manzoorwanijk manzoorwanijk changed the title [v10 backport] fix: linked strategy for scoped packages, aliases, and peer deps fix: linked strategy for scoped packages, aliases, and peer deps [v10 backport] Feb 23, 2026
@manzoorwanijk manzoorwanijk changed the title fix: linked strategy for scoped packages, aliases, and peer deps [v10 backport] fix: linked strategy for scoped packages, aliases, and peer deps [v10 backport] Feb 23, 2026
@manzoorwanijk manzoorwanijk marked this pull request as draft February 23, 2026 05:08
@manzoorwanijk
Copy link
Contributor Author

I am holding this off until #9013 is merged and then we can backport that as well.

@wraithgar
Copy link
Member

When it comes time to update this w/ the other PRs we have been landing please just bring in the new file as-is in one commit.

I do not care about my own git attribution, there's no need to try to preserve any of that.

@manzoorwanijk
Copy link
Contributor Author

manzoorwanijk commented Mar 4, 2026

@wraithgar
Copy link
Member

Do we also need the changes from #9055?

Yes I think it will make things much easier to bring in, and make future updates easier.

@wraithgar
Copy link
Member

I am also giving myself half of today to decide if #5820 is still worth looking at or if we will just close it and move on.

@manzoorwanijk manzoorwanijk changed the title fix: linked strategy for scoped packages, aliases, and peer deps [v10 backport] fix: port linked strategy fixes from multiple PRs [v10 backport] Mar 4, 2026
@manzoorwanijk manzoorwanijk marked this pull request as ready for review March 4, 2026 19:54
@manzoorwanijk
Copy link
Contributor Author

@wraithgar, thank you for the hint. This is now ready for review.

@manzoorwanijk manzoorwanijk changed the title fix: port linked strategy fixes from multiple PRs [v10 backport] fix: backport linked strategy fixes from multiple PRs to v10 Mar 4, 2026
@manzoorwanijk
Copy link
Contributor Author

manzoorwanijk commented Mar 4, 2026

I am not sure how to fix the "Check Git Status" failure, though. I ran node ./scripts/resetdeps.js and it updated the lockfile. Looks like @gar/promise-retry has incompatible engines.

@wraithgar
Copy link
Member

We just landed a deps update to the v10 branch, it's possible your fork is out of date.

@wraithgar
Copy link
Member

Oooooh the promise-retry! You'll wanna use promise-retry instead, v10 did not move over to @gar/promisify.

@manzoorwanijk manzoorwanijk force-pushed the v10 branch 2 times, most recently from 6a41dee to 83d79fc Compare March 4, 2026 20:04
These changes are from these commits

a2154cd - linked strategy fixes for scoped packages, aliases, peer deps
880ecb7 - skip postinstall on store links
26fa40e - workspace-filtered install with linked strategy
10d5302 - unwrap Link nodes in legacyPeerDeps
983742b - isolated mode code cleanup
a29aeee - retry bin-links on Windows EPERM
16fbe13 - resolve relative file: deps
8614b2a - avoid full reinstall on subsequent runs
@manzoorwanijk
Copy link
Contributor Author

Switching to promise-retry seems to work.

@wraithgar
Copy link
Member

@manzoorwanijk are we good to go here?

@manzoorwanijk
Copy link
Contributor Author

@manzoorwanijk are we good to go here?

Yes, I think so.

@wraithgar wraithgar merged commit 794f6c8 into npm:release/v10 Mar 4, 2026
39 checks passed
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants