fix: backport linked strategy fixes from multiple PRs to v10#9011
fix: backport linked strategy fixes from multiple PRs to v10#9011wraithgar merged 1 commit intonpm:release/v10from
Conversation
|
I am holding this off until #9013 is merged and then we can backport that as well. |
|
When it comes time to update this w/ the other PRs we have been landing please just bring in the new file as-is in one commit. I do not care about my own git attribution, there's no need to try to preserve any of that. |
Thank you. Do we also need the changes from #9055? These are the changes I am planning to cherry-pick
|
Yes I think it will make things much easier to bring in, and make future updates easier. |
|
I am also giving myself half of today to decide if #5820 is still worth looking at or if we will just close it and move on. |
|
@wraithgar, thank you for the hint. This is now ready for review. |
|
I am not sure how to fix the "Check Git Status" failure, though. I ran |
|
We just landed a deps update to the v10 branch, it's possible your fork is out of date. |
|
Oooooh the promise-retry! You'll wanna use |
6a41dee to
83d79fc
Compare
These changes are from these commits a2154cd - linked strategy fixes for scoped packages, aliases, peer deps 880ecb7 - skip postinstall on store links 26fa40e - workspace-filtered install with linked strategy 10d5302 - unwrap Link nodes in legacyPeerDeps 983742b - isolated mode code cleanup a29aeee - retry bin-links on Windows EPERM 16fbe13 - resolve relative file: deps 8614b2a - avoid full reinstall on subsequent runs
|
Switching to |
|
@manzoorwanijk are we good to go here? |
Yes, I think so. |
This contains the changes from
Since Node 22 doesn't have npm 11 yet, it would be better to have this change backported to v10
Also, we wish to use
install-strategy=linkedin the Gutenberg monorepo, which powers the WordPress Block Editor. We are still on v10. So, these fixes will help.